478 Commits

Author	SHA1	Message	Date
Philip Rebohle	5e55ced8b2	[dxvk] Fix deferred clear logic for overlapping image views ... If we clear the same image subresources twice with different views and then start rendering to one view, we may end up clearing to the wrong clear value.	2021-02-21 14:53:03 +01:00
Philip Rebohle	7168cc160f	[dxvk] Remove layout transition hack for presentable images	2021-02-21 02:19:44 +01:00
Philip Rebohle	e46bf78f31	[dxvk] Implement discardImageView ... Built on top of the deferred clear logic.	2021-02-21 01:56:52 +01:00
Joshua Ashton	80049c360e	[dxvk] Fix resource tracking in attachment transitions ... Fixes a crash in Portal 2 on DXVK native in which an old depth stencil is used after free after a device reset.	2021-02-20 19:34:49 +01:00
Philip Rebohle	5fc83a6075	[dxvk] Add missing trackImage to changeImageLayout	2021-02-20 14:35:57 +01:00
Philip Rebohle	df76a5252a	[dxvk] Use default layout for depth-stencil image descriptors ... Apparently the image layout matching rules were relaxed at some point, so just using DEPTH_STENCIL_READ_ONLY_OPTIMAL for descriptors is legal even if the image is in DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL or DEPTH_ATTACHMENT_STENCIL_READ_ONLY_OPTIMAL in the current render pass.	2021-02-15 17:00:35 +01:00
Philip Rebohle	a0cf5926d8	[dxvk] Add parameter to prepareImage to ignore clears ... Otherwise we may flush clears while clearing a render target, which is silly and undoes the layout optimizations.	2021-02-14 04:22:52 +01:00
Philip Rebohle	2b401725dc	[dxvk] Do not transition non-shared images at the end of the command buffer ... Currently, if the frontend flushes the command list, we always transition render targets to their default layout. This may lead to some arbitrary GPU performance issues if the transitions are not free. Instead, keep all images that are only used internally in their attachment layout across command list boundaries, until they are unbound.	2021-02-14 04:00:02 +01:00
Philip Rebohle	6efc2588f8	[dxvk] Remove checkFramebufferBarrier ... No longer serves any practical purpose.	2021-02-14 04:00:02 +01:00
Philip Rebohle	95676bf1e6	[dxvk] Always prepare images not bound to the current FB when clearing ... Fixes a potential bug when clearing a render target after the last render pass using it gets suspended. Also, for some reason we were checking for <1 instead of <0.	2021-02-14 04:00:02 +01:00
Philip Rebohle	0c18a86090	[dxvk] Fix render target clears if attachments are not tightly packed ... We do actually need to use the color target indices here rather than the attachment index, since the repacking happens inside DxvkRenderPass. Clear values still need to be tightly packed.	2021-02-12 03:13:11 +01:00
Philip Rebohle	0956050db6	[dxvk] Fix actual render target layout transitions for 3D images ... Also, only emit transitions if the layouts differ.	2021-02-12 03:13:11 +01:00
Philip Rebohle	bd87c12138	[dxvk] Make suspend parameter of spillRenderPass not optional	2021-02-12 03:13:11 +01:00
Philip Rebohle	aa0296b7ca	[dxvk] Suspend render pass for most image operations ... We can big brain this and only explicitly transition the render targets that are used within the copy operation, if any, and leave the rest intact.	2021-02-12 03:13:11 +01:00
Philip Rebohle	96dfac7fea	[dxvk] Suspend render pass for certain render target clears	2021-02-12 03:13:11 +01:00
Philip Rebohle	d7db413cac	[dxvk] Introduce prepareImage ... This transitions any framebuffer attachment that is currently in the wrong layout back to its default layout before it is used by functions that expec it to be in the default layout.	2021-02-12 03:13:10 +01:00
Philip Rebohle	fe43abbf32	[dxvk] Suspend render pass for buffer copies and render pass barriers ... No images are directly involved in these, so we can save some layout transitions.	2021-02-12 03:13:10 +01:00
Philip Rebohle	ba698430cb	[dxvk] Suspend render pass when updating framebuffer ... Saves barriers in case some of the previously bound framebuffer arre reused in the new one.	2021-02-12 03:13:10 +01:00
Philip Rebohle	d3b2db5978	[dxvk] Loosen render pass barriers ... Still use ALL_COMMANDS_BIT at the end to avoid potential WAR hazards for things like vertex buffers.	2021-02-12 03:13:10 +01:00
Philip Rebohle	29afaea338	[dxvk] Track current render target image layouts ... This can be used to optimize away some barriers and layout transitions.	2021-02-12 03:13:10 +01:00
Philip Rebohle	3caf5269f2	[dxvk] Add regular barrier after graphics queue depth image upload ... We still need a barrier for the layout transition.	2021-01-12 13:25:00 +01:00
Philip Rebohle	b19293430a	[dxvk] Execute depth/stencil image upload on graphics queue ... Silences a validation error.	2021-01-12 12:14:53 +01:00
Philip Rebohle	0ce5dd8b03	[dxvk] Remove conditional rendering from backend ... Was disabled anyway due to being broken on various drivers, so let's get rid of it.	2020-11-30 19:18:26 +01:00
Philip Rebohle	5e5937baf4	[dxvk] Pass size of 0 for dummy vertex buffer ... Silences some validation errors in case null descriptors are disabled.	2020-11-24 17:50:14 +01:00
Philip Rebohle	d256175981	[dxvk] Eliminate back-to-back clears when no render pass is active ... Trine 4 hits this with a multisampled depth buffer multiple times per frame. Previously, we'd only eliminate redudant clears if the render target to clear was active in the current render pass.	2020-11-21 03:03:15 +01:00
Philip Rebohle	ce33b60f9c	[dxvk] Remove null descriptor code paths for unbound resources	2020-07-10 16:59:20 +02:00
Philip Rebohle	2c641566ab	[dxvk] Fix inefficient check in bindVertexBuffer	2020-07-10 16:59:20 +02:00
Philip Rebohle	dfc0b740f8	[dxvk] Use vkCmdBindVertexBuffers2 to bind buffer ranges ... Potentially fixes problems with OOB access on dynamic vertex buffers.	2020-07-10 16:59:20 +02:00
Philip Rebohle	9ba99eba93	[dxvk] Add feature bit for extended dynamic state	2020-07-10 16:59:20 +02:00
Joshua Ashton	7cd46e72e9	[dxvk] Add filter type to generateMipmaps	2020-05-27 10:12:43 +02:00
Joshua Ashton	9a40c1e6ae	[dxvk] Fix fb resolve offset ... gl_FragCoord is read in the fs shader, so we need to take into account the dstOffset here! This was causing the offset to be doubled rather than eliminated for the resolves for refractive water in Serious Sam 2 as srcOffset == dstOffset. Fixes #1637	2020-05-22 11:13:07 +02:00
Philip Rebohle	0c0d582f24	[dxvk] Default to fragment shader resolved on official AMD drivers ... Improves performance of MSAA resolves. RADV does not benefit.	2020-05-19 18:54:25 +02:00
Philip Rebohle	5d7b5b0e35	[dxvk] Fix framebuffer resolve barriers	2020-05-19 16:23:44 +02:00
Philip Rebohle	6643c75f37	[dxvk] Use access flags rather than usage when tracking gfx barriers	2020-05-12 00:24:09 +02:00
Philip Rebohle	7239066c5c	[dxvk] Don't stall SDMA command buffer for image initialization	2020-05-02 20:20:56 +02:00
Philip Rebohle	4fafeb21d0	[dxvk] Optimize clearDepthStencilImage barrier	2020-05-02 20:13:13 +02:00
Philip Rebohle	e24954ca39	[dxvk] Optimize clearColorImage barrier	2020-05-02 20:13:13 +02:00
Philip Rebohle	52cad95f2c	[dxvk] Use initializeImage in clearColorImage	2020-05-02 20:13:13 +02:00
Philip Rebohle	bbd5762d3d	[dxvk] Add initializeImage helper ... Allows us to use TOP_OF_PIPE -> xxx barriers more often.	2020-05-02 20:10:19 +02:00
Philip Rebohle	a208f45fe4	[dxvk] Actually reinitialize image if necessary	2020-05-02 19:27:45 +02:00
Philip Rebohle	651646ca7f	[dxvk] Fix acquire barrier in clearCompressedColorImage	2020-05-02 19:06:22 +02:00
Philip Rebohle	dcc38c98e7	[dxvk] Fix acquire barriers in resolveImageHw	2020-05-02 18:58:38 +02:00
Philip Rebohle	b370d13743	[dxvk] Fix acquire barrier in updateImage	2020-05-02 18:52:35 +02:00
Philip Rebohle	8921be81bd	[dxvk] Fix blit acquire barriers	2020-05-02 18:49:58 +02:00
Philip Rebohle	85db84a1b3	[dxvk] Fix access mask in clearImageViewFb ... VK_ATTACHMENT_LOAD_OP_LOAD requires the read flags to be set.	2020-05-02 18:48:59 +02:00
Philip Rebohle	5bab5ae7a5	[dxvk] Fix acquire barriers in copyImageHw	2020-05-02 18:46:35 +02:00
Philip Rebohle	c1fcc3fc98	[dxvk] Simplify barriers around meta copy operations	2020-05-02 18:46:21 +02:00
Philip Rebohle	f6007e4f1a	[dxvk] Emit graphics barriers upon spilling render pass ... We actually need to do this now since we no longer set all the access flags in the render pass barrier.	2020-05-02 11:36:32 +02:00
Philip Rebohle	0245273ab7	[dxvk] Remove store op from render pass ops ... This is always going to be VK_ATTACHMENT_STORE_OP_STORE anyway.	2020-05-02 11:36:32 +02:00
Philip Rebohle	c0f72940dd	[dxvk] Optimize regular render pass barriers ... Only applies the depth/color attachment stage and access mask if necessary, and removes a bunch of pointless read-only flags.	2020-05-02 11:36:32 +02:00