backup/warcprox
1
0
Fork 0
mirror of https://github.com/internetarchive/warcprox.git synced 2025-01-18 13:22:09 +01:00
Code Issues Projects Releases Activity

Add entries to bad_hostnames_ports only on connection init

Browse Source 
Do not add entries to bad_hostnames_ports during connection running if
an exception occurs. Do it only on connection init because for some
unclear reason unit tests fail in that case.
This commit is contained in:
Vangelis Banos 2019-05-09 20:44:47 +00:00
parent bbe41bc900
commit 75e789c15f
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
warcprox/mitmproxy.py
View File

@ -549,12 +549,6 @@ class MitmProxyHandler(http_server.BaseHTTPRequestHandler):
if not is_connection_dropped(self._remote_server_conn):
self._conn_pool._put_conn(self._remote_server_conn)
except Exception as e:
if type(e) in (socket.timeout, NewConnectionError):
with self.server.bad_hostnames_ports_lock:
hostname_port = self._hostname_port_cache_key()
self.server.bad_hostnames_ports[hostname_port] = 1
self.logger.info('bad_hostnames_ports cache size: %d',
len(self.server.bad_hostnames_ports))
self._remote_server_conn.sock.shutdown(socket.SHUT_RDWR)
self._remote_server_conn.sock.close()
raise