backup/warcprox
1
0
Fork 0
mirror of https://github.com/internetarchive/warcprox.git synced 2025-01-18 13:22:09 +01:00
Code Issues Projects Releases Activity

fix plugin loading and add a rudimentary test case

Browse Source
This commit is contained in:
Noah Levitt 2018-01-18 11:38:24 -08:00
parent 87cdd855d4
commit 6cc6cf4f28
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tests/test_warcprox.py
View File

@ -1395,6 +1395,23 @@ def test_controller_with_defaults():
assert not wwt.writer_pool.default_warc_writer.record_builder.base32
assert wwt.writer_pool.default_warc_writer.record_builder.digest_algorithm == 'sha1'
def test_load_plugin():
options = warcprox.Options()
options.plugins = ['warcprox.stats.RunningStats']
controller = warcprox.controller.WarcproxController(options)
assert isinstance(
controller._postfetch_chain[-1],
warcprox.ListenerPostfetchProcessor)
assert isinstance(
controller._postfetch_chain[-1].listener,
warcprox.stats.RunningStats)
assert isinstance(
controller._postfetch_chain[-2],
warcprox.ListenerPostfetchProcessor)
assert isinstance(
controller._postfetch_chain[-2].listener,
warcprox.stats.RunningStats)
def test_choose_a_port_for_me(warcprox_):
options = warcprox.Options()
options.port = 0

2
warcprox/controller.py
View File

@ -97,7 +97,7 @@ class Factory:
(module_name, class_name) = qualname.rsplit('.', 1)
module_ = importlib.import_module(module_name)
class_ = getattr(module_, class_name)
listener = class_()
plugin = class_()
plugin.notify # make sure it has this method
return plugin
except Exception as e: