From 2b408b3af0b86227d42466773154aa3ab2abfeaa Mon Sep 17 00:00:00 2001 From: Noah Levitt Date: Fri, 13 Sep 2019 10:56:58 -0700 Subject: [PATCH] avoid this problem 2019-09-13 17:15:40,659 594 CRITICAL MainThread warcprox.controller.WarcproxController.run_until_shutdown(controller.py:447) graceful shutdown failed Traceback (most recent call last): File "/opt/warcprox-ve3/lib/python3.5/site-packages/warcprox/controller.py", line 445, in run_until_shutdown self.shutdown() File "/opt/warcprox-ve3/lib/python3.5/site-packages/warcprox/controller.py", line 371, in shutdown self.proxy.server_close() File "/opt/warcprox-ve3/lib/python3.5/site-packages/warcprox/warcproxy.py", line 503, in server_close warcprox.mitmproxy.PooledMitmProxy.server_close(self) File "/opt/warcprox-ve3/lib/python3.5/site-packages/warcprox/mitmproxy.py", line 754, in server_close for sock in self.remote_server_socks: RuntimeError: Set changed size during iteration --- warcprox/mitmproxy.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/warcprox/mitmproxy.py b/warcprox/mitmproxy.py index 6a7ce4c..2d7f9b6 100644 --- a/warcprox/mitmproxy.py +++ b/warcprox/mitmproxy.py @@ -759,7 +759,7 @@ class PooledMitmProxy(PooledMixIn, MitmProxy): Abort active connections to remote servers to achieve prompt shutdown. ''' self.shutting_down = True - for sock in self.remote_server_socks: + for sock in list(self.remote_server_socks): self.shutdown_request(sock) class SingleThreadedMitmProxy(http_server.HTTPServer):