backup/pywb
1
0
Fork 0
mirror of https://github.com/webrecorder/pywb.git synced 2025-03-24 06:59:52 +01:00
Code Issues Projects Releases Activity

head request replay fix: treat head requests as traditionally GET requests w/o payload, instead of HEAD request replay, see #309, mentioned in #307

Browse Source
This commit is contained in:
Ilya Kreymer 2018-03-05 13:08:22 -08:00
parent 98cdf36626
commit e812ed2d45
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pywb/warcserver/inputrequest.py
View File

@ -77,7 +77,7 @@ class DirectWSGIInputRequest(object):
method = self.get_req_method() method = self.get_req_method()
if method not in ('OPTIONS', 'HEAD', 'POST'): if method not in ('OPTIONS', 'POST'):
return url return url
mime = self._get_content_type() mime = self._get_content_type()

14
tests/test_integration.py
View File

@ -81,6 +81,20 @@ class TestWbIntegration(BaseConfigTest):
assert 'Content-Security-Policy' not in resp.headers assert 'Content-Security-Policy' not in resp.headers
def test_replay_content_head(self, fmod):
resp = self.head('/pywb/20140127171238{0}/http://www.iana.org/', fmod, status=200)
assert not resp.headers.get('Content-Length')
def test_replay_content_head_non_zero_content_length_match(self):
resp = self.testapp.get('/pywb/id_/http://www.iana.org/_js/2013.1/jquery.js', status=200)
length = resp.content_length
# Content-Length included if non-zero
resp = self.testapp.head('/pywb/id_/http://www.iana.org/_js/2013.1/jquery.js', status=200)
#assert resp.headers['Content-Length'] == length
assert resp.content_length == length
def test_replay_content(self, fmod): def test_replay_content(self, fmod):
resp = self.get('/pywb/20140127171238{0}/http://www.iana.org/', fmod) resp = self.get('/pywb/20140127171238{0}/http://www.iana.org/', fmod)
self._assert_basic_html(resp) self._assert_basic_html(resp)