From dcf3688dc3805de44c917d9c85efe928945770de Mon Sep 17 00:00:00 2001 From: Ilya Kreymer Date: Wed, 11 Feb 2015 19:26:45 -0800 Subject: [PATCH] wombat: also override frameElement when changing window.parent for top-level replay frame --- pywb/static/wombat.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/pywb/static/wombat.js b/pywb/static/wombat.js index 3f7ed511..6a2827b9 100644 --- a/pywb/static/wombat.js +++ b/pywb/static/wombat.js @@ -529,10 +529,11 @@ _WBWombat = (function() { if (equals_any(lowername, REWRITE_ATTRS) && typeof(value) == "string") { if (!this._no_rewrite) { var old_value = value; - value = rewrite_url(value); - if (value != old_value) { + var new_value = rewrite_url(value); + if (new_value != old_value) { this._no_rewrite = true; } + value = new_value; } } } @@ -983,8 +984,12 @@ _WBWombat = (function() { if (window.parent == window.top) { window.parent = window; + + // Disable frameElement also as this should be top frame + if (Object.defineProperty) { + Object.defineProperty(window, "frameElement", {value: undefined, configurable: false}); + } } - } else { window.top.WB_wombat_location = new WombatLocation(window.top.location); window.WB_wombat_top = window.top;