backup/pywb
1
0
Fork 0
mirror of https://github.com/webrecorder/pywb.git synced 2025-03-15 08:04:49 +01:00
Code Issues Projects Releases Activity

recorder: ensure request wrapper is closed if skipping recording upon seeing response

Browse Source
This commit is contained in:
Ilya Kreymer 2017-06-12 13:35:28 +01:00
parent 4518744b44
commit 7dae125888
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pywb/recorder/recorderapp.py
View File

@ -200,11 +200,14 @@ class RecorderApp(object):
skipping = any(x.skip_request(path, headers) for x in self.skip_filters)
req_is_wrapped = False
if not skipping:
req_stream = ReqWrapper(input_buff,
headers,
params,
self.create_buff_func)
req_is_wrapped = True
else:
req_stream = input_buff
@ -221,7 +224,7 @@ class RecorderApp(object):
stream=True)
res.raise_for_status()
except Exception as e:
if not skipping:
if req_is_wrapped:
req_stream.out.close()
return self.send_error(e, start_response)
@ -244,6 +247,8 @@ class RecorderApp(object):
else:
resp_stream = res.raw
if req_is_wrapped:
req_stream.out.close()
resp_iter = StreamIter(resp_stream)