From 3b68ef6540ca55c4f2ac180b3a6a12e3853ef4a1 Mon Sep 17 00:00:00 2001 From: Ilya Kreymer Date: Sun, 12 Jun 2016 01:57:21 -0400 Subject: [PATCH] html rewriter: cleanup rewrite_srcset, add more tests for empty rewrite --- pywb/rewrite/html_rewriter.py | 3 +-- pywb/rewrite/test/test_html_rewriter.py | 6 ++++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/pywb/rewrite/html_rewriter.py b/pywb/rewrite/html_rewriter.py index 1ae28b6a..90148c1f 100644 --- a/pywb/rewrite/html_rewriter.py +++ b/pywb/rewrite/html_rewriter.py @@ -216,8 +216,7 @@ class HTMLRewriterMixin(object): return '' values = value.split(',') - values = map(lambda x: self._rewrite_url(x.strip()), values) - values = [v for v in values if v is not None] + values = [self._rewrite_url(v.strip()) for v in values] return ', '.join(values) def _rewrite_css(self, css_content): diff --git a/pywb/rewrite/test/test_html_rewriter.py b/pywb/rewrite/test/test_html_rewriter.py index 30ca7da7..afb1da93 100644 --- a/pywb/rewrite/test/test_html_rewriter.py +++ b/pywb/rewrite/test/test_html_rewriter.py @@ -49,6 +49,12 @@ r""" >>> parse('', urlrewriter=no_base_canon_rewriter) +# Empty url +>>> parse('') + + +>>> parse('') + # HTML Entities