backup/pywb
1
0
Fork 0
mirror of https://github.com/webrecorder/pywb.git synced 2025-03-24 06:59:52 +01:00
Code Issues Projects Releases Activity

html_rewriter: handle parse_comments by rewriting as html, not as js, should address ikreymer/pywb-webrecorder#7

Browse Source
This commit is contained in:
Ilya Kreymer 2015-05-13 19:26:03 -07:00
parent f276eeba54
commit 11664c8277
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pywb/rewrite/html_rewriter.py
View File

@ -101,6 +101,7 @@ class HTMLRewriterMixin(object):
self.head_insert = head_insert self.head_insert = head_insert
self.parse_comments = parse_comments self.parse_comments = parse_comments
self.defmod = defmod
self.rewrite_tags = self._init_rewrite_tags(defmod) self.rewrite_tags = self._init_rewrite_tags(defmod)
# get opts from urlrewriter # get opts from urlrewriter
@ -391,7 +392,14 @@ class HTMLRewriter(HTMLRewriterMixin, HTMLParser):
def handle_comment(self, data): def handle_comment(self, data):
self.out.write('<!--') self.out.write('<!--')
if self.parse_comments: if self.parse_comments:
data = self._rewrite_script(data) #data = self._rewrite_script(data)
# Rewrite with seperate HTMLRewriter
comment_rewriter = HTMLRewriter(self.url_rewriter,
defmod=self.defmod)
data = comment_rewriter.rewrite(data)
data += comment_rewriter.close()
self.out.write(data) self.out.write(data)
else: else:
self.parse_data(data) self.parse_data(data)