From 0cf6b40af982ab9aa11d633c4131deda55ba8b51 Mon Sep 17 00:00:00 2001 From: Ilya Kreymer Date: Fri, 18 Dec 2015 21:46:50 -0800 Subject: [PATCH] wombat: add option to def_prop() to make overriden property enumerable, make WombatLocation and other loc overrides enumerable, fixes #163 --- pywb/static/wombat.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pywb/static/wombat.js b/pywb/static/wombat.js index b00023d2..7a1fd14f 100644 --- a/pywb/static/wombat.js +++ b/pywb/static/wombat.js @@ -364,7 +364,7 @@ var wombat_internal = function($wbwindow) { //============================================ // Override a DOM property - function def_prop(obj, prop, set_func, get_func) { + function def_prop(obj, prop, set_func, get_func, enumerable) { // if the property is marked as non-configurable in the current // browser, skip the override var existingDescriptor = Object.getOwnPropertyDescriptor(obj, prop); @@ -381,6 +381,7 @@ var wombat_internal = function($wbwindow) { try { var descriptor = { configurable: true, + enumerable: enumerable || false, get: get_func, }; @@ -519,7 +520,7 @@ var wombat_internal = function($wbwindow) { } function add_loc_prop(loc, prop) { - def_prop(loc, prop, make_set_loc_prop(prop), make_get_loc_prop(prop)); + def_prop(loc, prop, make_set_loc_prop(prop), make_get_loc_prop(prop), true); } if (Object.defineProperty) {