backup/OpenDX
1
0
Fork 0
mirror of https://github.com/EduApps-CDG/OpenDX synced 2024-12-30 09:45:37 +01:00
Code Issues Projects Releases Activity

[dxvk] Repurpose updateBuffer

Browse Source 
Only allow it for very small updates where scheduling a copy command would
likely be slower. Some drivers have special paths for tiny updates.
This commit is contained in:
Philip Rebohle 2022-02-12 14:37:11 +01:00
parent a03c038f03
commit 6a3de28f94
No known key found for this signature in database
GPG Key ID: C8CC613427A31C99
1 changed files with 6 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/dxvk/dxvk_context.cpp
View File

@ -2134,10 +2134,7 @@ namespace dxvk {
VkDeviceSize size, VkDeviceSize size,
const void* data) { const void* data) {
bool isHostVisible = buffer->memFlags() & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT; bool isHostVisible = buffer->memFlags() & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT;
bool replaceBuffer = size == buffer->info().size && !isHostVisible;
bool replaceBuffer = (size == buffer->info().size)
&& (size <= (1 << 18))
&& !isHostVisible;
DxvkBufferSliceHandle bufferSlice; DxvkBufferSliceHandle bufferSlice;
DxvkCmdBuffer cmdBuffer; DxvkCmdBuffer cmdBuffer;
@ -2165,34 +2162,11 @@ namespace dxvk {
m_execBarriers.recordCommands(m_cmd); m_execBarriers.recordCommands(m_cmd);
} }
// Vulkan specifies that small amounts of data (up to 64kB) can m_cmd->cmdUpdateBuffer(cmdBuffer,
// be copied to a buffer directly if the size is a multiple of bufferSlice.handle,
// four. Anything else must be copied through a staging buffer. bufferSlice.offset,
// We'll limit the size to 4kB in order to keep command buffers bufferSlice.length,
// reasonably small, we do not know how much data apps may upload. data);
if ((size <= 4096) && ((size & 0x3) == 0) && ((offset & 0x3) == 0)) {
m_cmd->cmdUpdateBuffer(
cmdBuffer,
bufferSlice.handle,
bufferSlice.offset,
bufferSlice.length,
data);
} else {
auto stagingSlice = m_staging.alloc(CACHE_LINE_SIZE, size);
auto stagingHandle = stagingSlice.getSliceHandle();
std::memcpy(stagingHandle.mapPtr, data, size);
VkBufferCopy region;
region.srcOffset = stagingHandle.offset;
region.dstOffset = bufferSlice.offset;
region.size = size;
m_cmd->cmdCopyBuffer(cmdBuffer,
stagingHandle.handle, bufferSlice.handle, 1, &region);
m_cmd->trackResource<DxvkAccess::Read>(stagingSlice.buffer());
}
auto& barriers = replaceBuffer auto& barriers = replaceBuffer
? m_initBarriers ? m_initBarriers