clean code, remove unused code

This commit is contained in:
Volker Berlin 2022-07-23 19:58:56 +02:00
parent fd3c698ef5
commit 4722445f24
No known key found for this signature in database
GPG Key ID: 988423EF815BE4CB

View File

@ -143,7 +143,7 @@ class BranchManager {
void addIfOperator( int startPosition, int offset, int lineNumber, WasmNumericInstruction instr ) { void addIfOperator( int startPosition, int offset, int lineNumber, WasmNumericInstruction instr ) {
JumpInstruction jump = new JumpInstruction( startPosition + offset, 1, null, startPosition, lineNumber ); JumpInstruction jump = new JumpInstruction( startPosition + offset, 1, null, startPosition, lineNumber );
instructions.add( jump ); instructions.add( jump );
allParsedOperations.add( new IfParsedBlock( startPosition, offset, lineNumber, instr, jump ) ); allParsedOperations.add( new IfParsedBlock( startPosition, offset, lineNumber, instr ) );
} }
/** /**
@ -546,33 +546,6 @@ class BranchManager {
} }
} }
/**
* Add a break to the node if the block jump to the continue position of an outer loop.
*
* @param parent
* the container for adding the break
* @param startBlock
* an IF or GOTO block.
* @return true, if the break was added
*/
private boolean addBreakIfLoopContinue( BranchNode parent, ParsedBlock startBlock ) {
BranchNode main = parent;
int endPos = startBlock.endPosition;
int breakDeep = 0;
while( main != null ) {
if( main.startOp == WasmBlockOperator.LOOP && main.continuePos == endPos ) {
// possible operation values here are IF and GOTO
WasmBlockOperator op = startBlock.op == JavaBlockOperator.IF ? WasmBlockOperator.BR_IF : WasmBlockOperator.BR;
int startPos = startBlock.nextPosition;
parent.add( new BranchNode( startPos, startPos, op, null, breakDeep ) );
return true;
}
main = main.parent;
breakDeep++;
}
return false;
}
/** /**
* Calculate the IF ELSE and END control structure. The resulting code in WebAssembly look like: * Calculate the IF ELSE and END control structure. The resulting code in WebAssembly look like:
* *
@ -725,6 +698,7 @@ class BranchManager {
newElsePositionFound = true; newElsePositionFound = true;
} }
break; break;
default:
} }
if( parsedBlock.startPosition > endElse ) { if( parsedBlock.startPosition > endElse ) {
parsedOpCount = i; parsedOpCount = i;
@ -783,7 +757,6 @@ class BranchManager {
} }
IfPositions pos = new IfPositions(); IfPositions pos = new IfPositions();
pos.ifCount = ifCount; pos.ifCount = ifCount;
pos.thenPos = thenPos;
pos.elsePos = elsePos; pos.elsePos = elsePos;
return pos; return pos;
} }
@ -1175,7 +1148,6 @@ class BranchManager {
BranchNode blockNode = new BranchNode( loopBlock.startPosition, loopBlock.endPosition, WasmBlockOperator.BLOCK, WasmBlockOperator.END ); BranchNode blockNode = new BranchNode( loopBlock.startPosition, loopBlock.endPosition, WasmBlockOperator.BLOCK, WasmBlockOperator.END );
parent.add( blockNode ); parent.add( blockNode );
BranchNode loopNode = new BranchNode( loopBlock.startPosition, loopBlock.endPosition, WasmBlockOperator.LOOP, WasmBlockOperator.END ); BranchNode loopNode = new BranchNode( loopBlock.startPosition, loopBlock.endPosition, WasmBlockOperator.LOOP, WasmBlockOperator.END );
loopNode.continuePos = loopBlock.nextPosition;
blockNode.add( loopNode ); blockNode.add( loopNode );
calculateSubOperations( loopNode, parsedOperations ); calculateSubOperations( loopNode, parsedOperations );
@ -1328,6 +1300,7 @@ class BranchManager {
WasmLoadStoreInstruction ex = (WasmLoadStoreInstruction)instructions.get( instrPos ); WasmLoadStoreInstruction ex = (WasmLoadStoreInstruction)instructions.get( instrPos );
node.add( new BranchNode( 0, 0, null, null ) { node.add( new BranchNode( 0, 0, null, null ) {
@Override
int handle(int codePosition, java.util.List<WasmInstruction> instructions, int idx, int lineNumber) { int handle(int codePosition, java.util.List<WasmInstruction> instructions, int idx, int lineNumber) {
if( codePosition == catchPos + 1 ) { if( codePosition == catchPos + 1 ) {
FunctionName instanceOf = options.getInstanceOf(); FunctionName instanceOf = options.getInstanceOf();
@ -1530,6 +1503,8 @@ class BranchManager {
case CATCH: case CATCH:
// first instruction of a CATCH block ever saved the exception from the stack to a local variable that we start the middle block an instruction later // first instruction of a CATCH block ever saved the exception from the stack to a local variable that we start the middle block an instruction later
startPos++; startPos++;
break;
default:
} }
} }
} }
@ -1624,8 +1599,6 @@ class BranchManager {
private WasmNumericInstruction instr; private WasmNumericInstruction instr;
private JumpInstruction jump;
/** /**
* Create new instance * Create new instance
* *
@ -1638,10 +1611,9 @@ class BranchManager {
* @param instr * @param instr
* the compare instruction * the compare instruction
*/ */
private IfParsedBlock( int startPosition, int offset, int lineNumber, WasmNumericInstruction instr, JumpInstruction jump ) { private IfParsedBlock( int startPosition, int offset, int lineNumber, WasmNumericInstruction instr ) {
super( JavaBlockOperator.IF, startPosition, offset, startPosition + 3, lineNumber ); super( JavaBlockOperator.IF, startPosition, offset, startPosition + 3, lineNumber );
this.instr = instr; this.instr = instr;
this.jump = jump;
} }
/** /**
@ -1755,8 +1727,6 @@ class BranchManager {
*/ */
private int startIdx; private int startIdx;
/** jump position for a CONTINUE in a loop */
private int continuePos;
/** /**
* Create a new description. * Create a new description.
@ -1996,6 +1966,8 @@ class BranchManager {
} catch( Throwable th ) { } catch( Throwable th ) {
throw WasmException.create( th, startBlock.getLineNumber() ); throw WasmException.create( th, startBlock.getLineNumber() );
} }
break;
default:
} }
} }
@ -2023,6 +1995,7 @@ class BranchManager {
case END: case END:
count--; count--;
break; break;
default:
} }
} }
if( count == 0 ) { if( count == 0 ) {
@ -2058,9 +2031,6 @@ class BranchManager {
/** Count of boolean operations in the IF top level condition. This can be (&&) or (||) operations. */ /** Count of boolean operations in the IF top level condition. This can be (&&) or (||) operations. */
private int ifCount; private int ifCount;
/** The position of the first instruction in the THEN part. */
private int thenPos;
/** The position of the first instruction in the ELSE part. */ /** The position of the first instruction in the ELSE part. */
private int elsePos; private int elsePos;
} }